From 51b816025183801f5953d849fe4ea83cd9385582 Mon Sep 17 00:00:00 2001 From: Luke Hoersten Date: Mon, 15 Jun 2026 07:23:47 -0500 Subject: firmware: zero-copy JPEG → BGR888 → DSI hot path; Scrypted pre-rotates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Architectural rework of the /frame hot path. Scrypted now ships every JPEG already scaled + rotated to the panel's native dimensions (read from the firmware's /state response so nothing is hardcoded on the Scrypted side); the firmware decodes the JPEG straight into a BGR888 buffer that's directly draw_bitmap'able by the DSI driver, with zero CPU pixel work and zero rotation work in between. Firmware - jpeg_decoder now uses JPEG_DECODE_OUT_FORMAT_RGB888 + JPEG_DEC_RGB_ELEMENT_ORDER_BGR. Output buffer sized for 800*480*3. - New display_present_bgr888() is a one-liner that hands the decoder's output straight to esp_lcd_panel_draw_bitmap. - /frame handler validates dimensions against the panel-native VIEWPORT_PANEL_WIDTH x VIEWPORT_PANEL_HEIGHT (was effective_dims branching on orientation). Returns 400 if it's anything else. - /state JSON adds panel_width + panel_height so Scrypted can read them without hardcoding board-specific knowledge. - display_present_rgb565 + s_rot_buf stay for the local-screens cold path (info screen, loading) which still does its own CPU conversion + rotation — infrequent enough that it's not worth the rewrite. Scrypted - startStream() GETs /state at stream-start time, caches panel_width and panel_height in viewport storage, and uses them as the ffmpeg scale target. Falls back to cached or 800x480 if /state is mid-reboot. - For portrait viewports the ffmpeg pipeline now does scale=H:W:flags=lanczos,transpose=1 so the JPEG arrives pre-rotated 90° CW into panel-native dimensions. Landscape is just scale=W:H. - No more in-firmware rotation; Scrypted is the single source of truth for "how do I get this camera frame into a panel-shaped JPEG". Expected ceiling lift: ~5 fps → ~10 fps, gated by the JPEG decoder hardware throughput instead of the CPU rgb565→bgr888 + rotation loop. --- main/display.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'main/display.h') diff --git a/main/display.h b/main/display.h index 9092efb..5f939b9 100644 --- a/main/display.h +++ b/main/display.h @@ -31,7 +31,16 @@ esp_err_t display_wake(void); // orientation. Source dimensions must match the effective resolution: // portrait -> src is 480x800 (rotated 90° CW into the 800x480 panel) // landscape -> src is 800x480 (copied 1:1) -// Used by /frame after JPEG decode. +// CPU-rotation + format-conversion path used by local_screens for the +// info / loading screens (cold path). /frame uses the zero-copy +// BGR888 path below. esp_err_t display_present_rgb565(const uint16_t *src, uint16_t src_w, uint16_t src_h); + +// Zero-copy hot path. Source is already 800x480 with bytes in [B, G, R] +// memory order (i.e. the format the panel pipeline natively wants); +// hand it straight to esp_lcd_panel_draw_bitmap. No CPU pixel work, no +// format conversion, no rotation — Scrypted is responsible for sending +// the buffer pre-rotated and pre-scaled to panel-native dimensions. +esp_err_t display_present_bgr888(const void *bgr888); -- cgit v1.2.3